Reviews for Proxy Toggle
Proxy Toggle by Richard West
Review by Manuel Maurer
Rated 5 out of 5
by Manuel Maurer, 4 years agoSuper easy to use. However, it will only detect internal IPs or specific internal domains. Domains that are mapped to an internal IP via DNS are not detected. I've tested it with Line 103 of background.js changed to return(isLocalIPv4(host) || isLocalIPv4(dns.resolve(host))); and it seems to work (needs dns permissions though)
Developer response
posted 4 years agoI'm not sure what the performance impact of that is, since that function is called for every request the browser makes. Not resolving DNS was a deliberate choice, and is why the option text mentions LAN IPs. It's fast (since we're just doing a simple pattern match) but imperfect.
It might be that it doesn't make much difference if the lookup is always cached internally by Firefox already, but the resolve documentation is a bit light on detail, so I don't know if we can rely on that or not.
It might be that it doesn't make much difference if the lookup is always cached internally by Firefox already, but the resolve documentation is a bit light on detail, so I don't know if we can rely on that or not.