Reviews for Bookmark search plus 2
Bookmark search plus 2 by aaFn
Review by nur
Rated 5 out of 5
by nur, 2 years agoIndispensable add-on.
One small problem when I (mistakenly) open two Properties dialogs for the same bookmark.
1. Create a bookmark "testA" and press Save.
2. Right-click the bookmark "testA" and open Properties. Let's call this dialog2.
3. Right-click the bookmark "testA" again and open Properties. Let's call this dialog3.
4. Edit the title of dialog3 to "testB" and Save. The bookmark correctly changes to "testB".
5. Switch the focus to dialog2.
6. Don't edit dialog2 and just press its Cancel or X button. It will close.
7. But then, the bookmark automatically changes its title back to "testA".
I expect it to keep "testB", because I pressed Cancel for dialog2.
(Reply to Developer response):
Yes, limiting property windows to single instances sounds better.
Additional note. I called it a "dialog", but unlike modal dialogs, it is actually a non-modal window, and this is very convenient because I can copy and paste multiple text and URL from the browser's webpage into the properies, and vice versa. I can even swap multiple portions between two bookmarks. So keep it non-modal, if possible.
(Reply to update 05/11/2023)
Dialog in 2.0.119 works as expected.
I also add my thanks for your implementing the Undo feature.
One small problem when I (mistakenly) open two Properties dialogs for the same bookmark.
1. Create a bookmark "testA" and press Save.
2. Right-click the bookmark "testA" and open Properties. Let's call this dialog2.
3. Right-click the bookmark "testA" again and open Properties. Let's call this dialog3.
4. Edit the title of dialog3 to "testB" and Save. The bookmark correctly changes to "testB".
5. Switch the focus to dialog2.
6. Don't edit dialog2 and just press its Cancel or X button. It will close.
7. But then, the bookmark automatically changes its title back to "testA".
I expect it to keep "testB", because I pressed Cancel for dialog2.
(Reply to Developer response):
Yes, limiting property windows to single instances sounds better.
Additional note. I called it a "dialog", but unlike modal dialogs, it is actually a non-modal window, and this is very convenient because I can copy and paste multiple text and URL from the browser's webpage into the properies, and vice versa. I can even swap multiple portions between two bookmarks. So keep it non-modal, if possible.
(Reply to update 05/11/2023)
Dialog in 2.0.119 works as expected.
I also add my thanks for your implementing the Undo feature.
Developer response
posted 2 years agoHello, thank you.
I guess I see in fact 2 changes to do here:
- when opening properties, if already open, re-focus on the already open one instead of opening a second one (I will verify this is possible)
- currently, when changing the value of a field in the property window, the bookmark value is immediately changed = this was the old behavior of FF when I created the add-on some years ago, a bit strange but this is what it was .. and so I mimicked it .. and so Cancel is restoring the old values when opening the property window.
However, this behavior now changed in FF, so I will look at going back to a more natural flow, where values are only changed when pressing "Save" (and so Cancel should do nothing, as the name says).
============ update 05/11/2023 ===========
Both changes made in 2.0.119 which is out now. Let me know on https://github.com/aaFn/Bookmark-search-plus-2/issues if any problem.
And yes, this is non modal. And by the way, it can't be modal, as the FF Web extension (add-ons) API does not allow modal windows as of today, to my knowledge.
Thank you, aaFn.
I guess I see in fact 2 changes to do here:
- when opening properties, if already open, re-focus on the already open one instead of opening a second one (I will verify this is possible)
- currently, when changing the value of a field in the property window, the bookmark value is immediately changed = this was the old behavior of FF when I created the add-on some years ago, a bit strange but this is what it was .. and so I mimicked it .. and so Cancel is restoring the old values when opening the property window.
However, this behavior now changed in FF, so I will look at going back to a more natural flow, where values are only changed when pressing "Save" (and so Cancel should do nothing, as the name says).
============ update 05/11/2023 ===========
Both changes made in 2.0.119 which is out now. Let me know on https://github.com/aaFn/Bookmark-search-plus-2/issues if any problem.
And yes, this is non modal. And by the way, it can't be modal, as the FF Web extension (add-ons) API does not allow modal windows as of today, to my knowledge.
Thank you, aaFn.