Reviews for Open in new tab
Open in new tab by Ramkumar K R
Review by Mirko
Rated 5 out of 5
by Mirko, 7 years agoPlease, change tabify.js this way:
for(var item in items){
var re = new RegExp( '^'+item.replace('*','.*')+'$' );
if (re.test(hostName)){
addTarget();
}
}
This would allow us to specify domain* or *domain or even * as hostname (to allow all opening in new tab for all domains).
A secondary field "exclude domains" would improve this further. If Allowed (*) and not Denied, thus addTarget.
Thank you
for(var item in items){
var re = new RegExp( '^'+item.replace('*','.*')+'$' );
if (re.test(hostName)){
addTarget();
}
}
This would allow us to specify domain* or *domain or even * as hostname (to allow all opening in new tab for all domains).
A secondary field "exclude domains" would improve this further. If Allowed (*) and not Denied, thus addTarget.
Thank you
Developer response
posted 7 years agoHi,
Thanks for the suggestion. It is a wonderful idea to define a regex for the hostname.
However, there are few concerns such as the actions to be shown in the popup when a regex matches the url
Can you send a pull request so that we can discuss more about it there?
Link to the repo- https://github.com/ramkumar-kr/open-in-new-tab
Thanks
Thanks for the suggestion. It is a wonderful idea to define a regex for the hostname.
However, there are few concerns such as the actions to be shown in the popup when a regex matches the url
Can you send a pull request so that we can discuss more about it there?
Link to the repo- https://github.com/ramkumar-kr/open-in-new-tab
Thanks