Reviews for Wingman Jr. Filter
Wingman Jr. Filter by Zephyr
Response by Zephyr
Developer response
posted 2 years agoHello! Thanks for the detailed report. For those interested in the end result only, there was a bug that seems to have affected private mode primarily and I have a minor bug fix release 3.3.1 rolling out to correct the issue.
Now for the more technical details.
As a fellow developer, I could see where you would get the impression that the two use cases you described (image reveal, and I'm assuming "view image" is the recently moved function "open image in a new tab") are not supported because they were broken on this site. Fortunately, both are generally supported. The way the code actually works largely bypasses DOM mutation observers and instead drops directly down to the connection itself (webRequest filtering). While this can have issues, it is generally robust to DOM types of issues like you describe.
When I took a look at your report, I was able to reproduce the issue in private mode - but it appears to have more to do with a subtle JS quirk than with either of those two cases per se. See the root cause (with original reported issues linked) here: https://github.com/wingman-jr-addon/wingman_jr/issues/180 I'm still not 100% sure what is triggering the differentiation in behavior, but apparently something with the assignment to the captured variable fails under some conditions, so I've pulled it.
At any rate, when you get a chance and 3.3.1 is out, would you be willing to give it another shot and see if your issue is resolved? (Do note you may wish to bump up the zone manually to untrusted for vndb.org for best results.) I'm glad to hear that it sounded like it was working well for you on other sites, so if I'm able to turn this around into a positive review, I'd appreciate a second chance. Thanks!
Now for the more technical details.
As a fellow developer, I could see where you would get the impression that the two use cases you described (image reveal, and I'm assuming "view image" is the recently moved function "open image in a new tab") are not supported because they were broken on this site. Fortunately, both are generally supported. The way the code actually works largely bypasses DOM mutation observers and instead drops directly down to the connection itself (webRequest filtering). While this can have issues, it is generally robust to DOM types of issues like you describe.
When I took a look at your report, I was able to reproduce the issue in private mode - but it appears to have more to do with a subtle JS quirk than with either of those two cases per se. See the root cause (with original reported issues linked) here: https://github.com/wingman-jr-addon/wingman_jr/issues/180 I'm still not 100% sure what is triggering the differentiation in behavior, but apparently something with the assignment to the captured variable fails under some conditions, so I've pulled it.
At any rate, when you get a chance and 3.3.1 is out, would you be willing to give it another shot and see if your issue is resolved? (Do note you may wish to bump up the zone manually to untrusted for vndb.org for best results.) I'm glad to hear that it sounded like it was working well for you on other sites, so if I'm able to turn this around into a positive review, I'd appreciate a second chance. Thanks!