Reviews for Youtube blind redirect
Youtube blind redirect by 0x08
Review by egoone
Rated 5 out of 5
by egoone, 3 years agoA review is probably not the proper forum for this communication, but as this is your only review, I thought I'd give it a go...
Hey, 0x08 I just tried this addon, and I found a couple of problems. One you already found, and the other, I don't think you found it yet.
First, this did not work for me. Because I happen to write user scripts for myself and wanted this to work, I looked at the js file in the extension.
At first I noticed that the variable waitSecs was set but not used.
While I was looking at this, you updated the addon. Not kidding.
The second problem still remaining is that it fails to find a collection of link elements using the selector "a[href^='/redir']"
using the mozilla reference for selectors, I tried instead to use:
"a[href*='/redir']" - which of course matches all links containing
the substring '/redir' which is what you wanted to do.
I tested this change, and that fixed the issue.
I copied and pasted these into a user script, and tried it. The other change I needed - because it is a user script, it is loaded to late to receive the 'DOMContentLoaded' event, so I had to explicitly trigger it to test it.
Hey, 0x08 I just tried this addon, and I found a couple of problems. One you already found, and the other, I don't think you found it yet.
First, this did not work for me. Because I happen to write user scripts for myself and wanted this to work, I looked at the js file in the extension.
At first I noticed that the variable waitSecs was set but not used.
While I was looking at this, you updated the addon. Not kidding.
The second problem still remaining is that it fails to find a collection of link elements using the selector "a[href^='/redir']"
using the mozilla reference for selectors, I tried instead to use:
"a[href*='/redir']" - which of course matches all links containing
the substring '/redir' which is what you wanted to do.
I tested this change, and that fixed the issue.
I copied and pasted these into a user script, and tried it. The other change I needed - because it is a user script, it is loaded to late to receive the 'DOMContentLoaded' event, so I had to explicitly trigger it to test it.
1 review
There are no reviews